Allow different ordering in Fortran scheme and associated metadata#666
Merged
Conversation
gold2718
requested review from
climbfuji,
dustinswales,
grantfirl,
mkavulich,
mwaxmonsky and
peverwhee
as code owners
climbfuji
approved these changes
Jul 22, 2025
|
|
||
| ## Metadata table types where order is significant | ||
| _ORDERED_TABLE_TYPES = [SCHEME_HEADER_TYPE] | ||
| _ORDERED_TABLE_TYPES = [] |
Collaborator
There was a problem hiding this comment.
Do we still need _ORDERED_TABLE_TYPES? I assume the answer is yes ...
peverwhee
approved these changes
Jul 24, 2025
Collaborator
peverwhee
left a comment
peverwhee
left a comment
There was a problem hiding this comment.
Thanks @gold2718 ! This make sense, but I'm curious about how this might impact the host model metadata comparison where the local names do not match?
Obviously the tests work so that functionality isn't broken. But I guess my question is... why?
dustinswales
approved these changes
Jul 24, 2025
Member
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
@gold2718 Thanks for the fast solution and PR!
Collaborator
|
@gold2718 Dustin & Dom helped me understand my host model metadata confusion. Ignore my comment! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow flexible Fortran scheme argument ordering
In checking compatibility between Fortran and metadata, schemes were required to have
arguments in the same order. This PR removes that restriction.
User interface changes?: No
Fixes: #665
Testing:
unit tests: Modified one test Fortran file to use a different argument ordering in the Fortran scheme.
system tests:
manual testing: manually ran unit tests